endSessionDialog: Immediately return from Open()

There's no need to wait for the dialog to finish fading in before we can
return from Open().

The code, as it was before, would break dialog updates: the dialog was
already open, so the signal would never get emitted, so the method would
never return, and so gnome-session would remain blocked waiting for a
return value that will never come.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/4040>

diff --git a/js/ui/endSessionDialog.js b/js/ui/endSessionDialog.js
index fdb0182eadf8f222dcfd99a8a4230e45c71a703e..7b666f090a441a1275687484f1a69c24c6aa4ce8 100644 (file)
--- a/js/ui/endSessionDialog.js
+++ b/js/ui/endSessionDialog.js
@@ -729,10 +729,7 @@ class EndSessionDialog extends ModalDialog.ModalDialog {
 
         this._sync();
 
-        const signalId = this.connect('opened', () => {
-            invocation.return_value(null);
-            this.disconnect(signalId);
-        });
+        invocation.return_value(null);
     }
 
     Close(_parameters, _invocation) {